Bugfix FXIOS-10437 [Menu] Attempt fix for menu coordinator bug (backport #23458) #23479
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Attempt fix * swifliiiiiint (cherry picked from commit b421b9a)
6 tasks
adudenamedruby
requested review from
adudenamedruby
and removed request for
dataports
adudenamedruby
approved these changes
Nov 29, 2024
Client.app: Coverage: 30.94
Generated by 🚫 Danger Swift against bba8c89 |
lovsroo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
IN the strange case that a coordinator exists, we dismiss relevant modals and remove the coordinator, and then re-add it properly, to ensure that the correct window UUID is being passed in. Logs have been added to help diagnose if it's not actually the correct window UUID.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)This is an automatic backport of pull request #23458 done by [Mergify](https://mergify.com).